Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

More pybind11 compilation memory savings #373

Merged
merged 5 commits into from
Feb 3, 2022
Merged

More pybind11 compilation memory savings #373

merged 5 commits into from
Feb 3, 2022

Conversation

scpeters
Copy link
Member

@scpeters scpeters commented Feb 3, 2022

🦟 Bug fix

Follow-up to #371

Summary

This continues moving template instantiations from _ignition_math_pybind11.cc to a separate translation unit for templates in each of the following header files:

  • Filter.hh
  • Line2.hh
  • Line3.hh
  • MovingWindowFilter.hh
  • Vector3.hh
  • Vector4.hh

Checklist

  • Signed all commits for DCO
  • Added tests
  • Updated documentation (as needed)
  • Updated migration guide (as needed)
  • codecheck passed (See contributing)
  • All tests passed (See test coverage)
  • While waiting for a review on your PR, please help review another open pull request to support the maintainers

Note to maintainers: Remember to use Squash-Merge and edit the commit message to match the pull request summary while retaining Signed-off-by messages.

@github-actions github-actions bot added Gazebo 1️1️ Dependency of Gazebo classic version 11 🏢 edifice Ignition Edifice 🏯 fortress Ignition Fortress 🏰 citadel Ignition Citadel labels Feb 3, 2022
@codecov
Copy link

codecov bot commented Feb 3, 2022 •
edited
Loading

Codecov Report

Merging #373 (ca1321d) into ign-math6 (3d0b05c) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           ign-math6     #373   +/-   ##
==========================================
  Coverage      99.65%   99.65%           
==========================================
  Files             67       67           
  Lines           6380     6380           
==========================================
  Hits            6358     6358           
  Misses            22       22

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 3d0b05c...ca1321d. Read the comment docs.

@scpeters scpeters merged commit 3c8a8fa into gazebosim:ign-math6 Feb 3, 2022
@scpeters scpeters deleted the pybind_translation_units branch February 3, 2022 18:04
@scpeters scpeters mentioned this pull request Mar 6, 2022
Merged
7 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ahcorde ahcorde ahcorde approved these changes

Assignees
No one assigned
Labels
🏰 citadel Ignition Citadel 🏢 edifice Ignition Edifice 🏯 fortress Ignition Fortress Gazebo 1️1️ Dependency of Gazebo classic version 11
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@scpeters @ahcorde